I don't have any of these chips but I would test them out if I had one.Īs far as distribution, you can put it in the Playground section ( Arduino Playground - HomePage) or upload it to GitHub ( ). You have lots of header comments but very few comments in the code itself.Since this is a C++ class why not make the AT93 Class an abstract base class and have the different versions of the part be subclasses?.I am not sure how long digitalWrite's take but you want to make sure you don't exceed the max Fsk frequency.You have a mixture of byte/word and uint types, why not just stick with all one or the other?._shiftIn and _shiftOut have access to the private variables there is no need to pass them in as parameters.Give them a name so they make your code more readable. There are a lot of magic numbers (i.e.I have looked over your code and I think it's a great start. Sounds like you are in the same boat as me.
0 Comments
Leave a Reply. |
AuthorWrite something about yourself. No need to be fancy, just an overview. ArchivesCategories |